Skip to content

[dev.fuzz] internal/fuzz: always perform logical not on booleans when… #48292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[dev.fuzz] internal/fuzz: always perform logical not on booleans when… #48292

wants to merge 1 commit into from

Conversation

stevenjohnstone
Copy link
Contributor

@stevenjohnstone stevenjohnstone commented Sep 9, 2021 •
edited
Loading

… mutating

Flip booleans when mutating rather than keeping the same value
50% of the time.

Updates #48291.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 9, 2021
@stevenjohnstone stevenjohnstone mentioned this pull request Sep 9, 2021
Open
@gopherbot
Copy link
Contributor

This PR (HEAD: 7159d6e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/348849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/348849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Steven Johnstone:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/348849.
After addressing review feedback, remember to publish your drafts!

@stevenjohnstone
[dev.fuzz] internal/fuzz: always perform logical not on booleans when…
5bf15b0 
… mutating

Flip booleans when mutating rather than keeping the same value
50% of the time.

Updates golang#48291.
@gopherbot
Copy link
Contributor

This PR (HEAD: 5bf15b0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/348849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/348849 has been abandoned.

Thanks. dev.fuzz has been merged to tip, if we still want this change it needs to be redone there.

@gopherbot gopherbot closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjohnstone @gopherbot